Skip to content

Fix up some older nonsense in CI/node #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 18, 2025
Merged

Fix up some older nonsense in CI/node #497

merged 1 commit into from
May 18, 2025

Conversation

mattgodbolt
Copy link
Owner

No description provided.

@mattgodbolt mattgodbolt requested a review from Copilot May 18, 2025 20:35
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the CI configurations for Node.js by aligning version numbers and streamlining related scripts and documentation. Key changes include:

  • Upgrading Node.js versions in package.json, Dockerfile, and GitHub Actions.
  • Consolidating and renaming test and lint scripts in package.json and associated documentation in CLAUDE.md.
  • Updating runner images and job names in the GitHub workflows.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
package.json Updated Node engine version and streamlined scripts including lint commands.
Dockerfile Upgraded Node image version from 20-alpine to 22-alpine to match package.json.
CLAUDE.md Revised documentation to reflect new test and coverage script commands.
.github/workflows/test-and-deploy.yml Switched to ubuntu-24.04 runners and updated Node.js version and job names.
Comments suppressed due to low confidence (2)

.github/workflows/test-and-deploy.yml:7

  • Ensure that upgrading to Ubuntu 24.04 along with Node.js version 22 does not introduce compatibility issues with any of the actions or dependencies used within the workflow.
runs-on: ubuntu-24.04

CLAUDE.md:16

  • [nitpick] Verify that the newly added CPU test command and other test script updates are well documented with context on when and why to use them.
+ `npm run test:cpu` - Run CPU compatibility tests

"ci-checks": "eslint .",
"lint": "eslint .",
"lint-fix": "eslint . --fix",
"lint": "eslint . --fix",
Copy link
Preview

Copilot AI May 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The 'lint' script now always applies fixes. Consider retaining a separate non-fix lint command to allow running lint checks without making automatic modifications.

Copilot uses AI. Check for mistakes.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's what ci-checks does

@mattgodbolt mattgodbolt merged commit 27f0cc4 into main May 18, 2025
3 checks passed
@mattgodbolt mattgodbolt deleted the ci-fixups branch May 18, 2025 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant