Add support for Firefox OS phones and tablets #38
Conversation
|
@miketaylr This is great! Mind removing the lib/* files? I need to clarify that in the README Contributing guidelines. Sorry about that :( |
|
Oh yeah, no probs @matthewhudson. |
Add support for Firefox OS phones and tablets
|
@miketaylr Mind adding the User Agent's you tested against to the following task: #34 They'll be needed in order to add tests (which are long overdue). |
| @@ -56,11 +56,20 @@ device.windowsPhone = -> | |||
| device.windowsTablet = -> | |||
| device.windows() and _find 'touch' | |||
|
|
|||
| device.fxos = -> | |||
| _find('(mobile; rv:') or _find('(tablet; rv:') | |||
There was a problem hiding this comment.
To account for device IDs that some vendors put inbetween Mobile; and rv: this should probably be:
_find('mobile') and _find('firefox') and not _find('android')
There was a problem hiding this comment.
I know @miketaylr intends to do something about that problem, whether he uses that suggestion or not :)
There was a problem hiding this comment.
Actually, this diff is old--the current master does fine with device ids. http://matthewhudson.me/projects/device.js/ just needs to be updated to 0.1.58. :)
There was a problem hiding this comment.
Version bumped - sorry for the confusion. Sussing out the details to prevent this from happening again.
No description provided.