feat(create-context): don't use Shadow Root. #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Context's Consumer component does not need to have a ShadowRoot because it would be very hard to style elements inside it. (part) fixes matthewp#384
🦋 Changeset detectedLatest commit: 4cb9621 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for hauntedhooks ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
@matthewp or @bennypowers Can you please have a look at this? It is very inconvenient for context consumer elements to have Shadow DOM. |
bennypowers
approved these changes
Mar 21, 2023
megheaiulian
force-pushed
the
feat/context-consumer-without-shadow-dom
branch
from
e6b64b2
to
4cb9621
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Context's Consumer component does not need to have a ShadowRoot because it would be very hard to style elements inside it. (part)
fixes #384