Don't shorten bools if they're object literal keys

Fixes issue #134
matthiasmullie · Sep 14, 2016 · f03da3f · f03da3f
1 parent 9e0dfaf
commit f03da3f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/src/JS.php b/src/JS.php
@@ -479,8 +479,8 @@ protected function propertyNotation($content)
      */
     protected function shortenBools($content)
     {
-        $content = preg_replace('/\btrue\b/', '!0', $content);
-        $content = preg_replace('/\bfalse\b/', '!1', $content);
+        $content = preg_replace('/\btrue\b(?!:)/', '!0', $content);
+        $content = preg_replace('/\bfalse\b(?!:)/', '!1', $content);
 
         // for(;;) is exactly the same as while(true)
         $content = preg_replace('/\bwhile\(!0\){/', 'for(;;){', $content);

diff --git a/tests/js/JSTest.php b/tests/js/JSTest.php
@@ -775,6 +775,12 @@ function otherFuncName() {
             'if(args.message instanceof Array){args.message=args.message.join(\' \')}',
         );
 
+        // https://github.com/matthiasmullie/minify/issues/134
+        $tests[] = array(
+            'e={true:!0,false:!1}',
+            'e={true:!0,false:!1}',
+        );
+
         // update tests' expected results for cross-system compatibility
         foreach ($tests as &$test) {
             if (!empty($test[1])) {