Fix Windows installation when username has space in it#634
Open
chaos95 wants to merge 2 commits intomattn:masterfrom
Open
Fix Windows installation when username has space in it#634chaos95 wants to merge 2 commits intomattn:masterfrom
chaos95 wants to merge 2 commits intomattn:masterfrom
Conversation
- Modify run_unzip.cmd to wrap invocations and paths in quotes - This prevents issues where a user's home directory has spaces in it due to their username, such as 'C:\Users\FirstName LastName', from causing commands to fail because they parse the different parts of the path as separate arguments.
- This change applies the same fix to run_gzip.cmd as the previous commit.
Owner
|
I suspect that this modification will make it even worse. Current implementation: test.c test.bat And with change test.bat |
Contributor
Author
|
True. I think it might be sufficient to wrap the commands in quotes and leave the arguments unquoted. For all of the invocations of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change modifies run_unzip.cmd and run_gzip.cmd to wrap invocations and paths in quotes.
This prevents issues arising where a user's home directory has spaces in it due to their username, such as 'C:\Users\FirstName LastName', which causes commands to fail because they parse the different parts of the path as separate arguments.
This change is not a complete solution - there are still quite a few individual installer scripts that make use of
%~dp0without quotes, but these central changes to unzip and gzip should solve the problem for at least a few people. I would be happy to submit future PRs for the individual installers as time permits.