Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typescript.tsx to settings.json #636

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 40 additions & 0 deletions settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -1575,6 +1575,46 @@
"requires": []
}
],
"typescript.tsx": [
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I understand, This name does not work.

Copy link
Contributor Author

@amadeus amadeus Dec 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been using this convention for years with my own typescript plugin and it works fine?

{
"command": "typescript-language-server",
"url": "https://github.com/typescript-language-server/typescript-language-server",
"description": "TypeScript & JavaScript Language Server",
"requires": [
"npm"
],
"root_uri_patterns": [
"package.json",
"tsconfig.json"
]
},
{
"command": "eslint-language-server",
"url": "https://www.npmjs.com/package/eslint-language-server",
"description": "eslint language server",
"requires": [
"node"
],
"root_uri_patterns": [
"package.json",
"tsconfig.json"
]
},
{
"command": "rome",
"url": "https://github.com/rome/tools",
"description": "The Rome Toolchain. A linter, compiler, bundler, and more for JavaScript, TypeScript, HTML, Markdown, and CSS.",
"requires": [
"npm"
]
},
{
"command": "deno",
"url": "https://deno.land/",
"description": "A modern runtime for JavaScript and TypeScript.",
"requires": []
}
],
"vala": [
{
"command": "vala-language-server",
Expand Down