Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Quick filters docs #208

Open
wants to merge 2 commits into
base: 5.x
Choose a base branch
from

Conversation

andersonjeccel
Copy link
Contributor

By following these guidelines, developers can easily create and implement new quick filters in Mautic, enhancing the user experience and search functionality.

Copy link
Member

@RCheesley RCheesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly Vale fixes here!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see notes on other PRs about the heading nesting:

H1 ###
H2 ***
H3 ===
H4 ---
H5 ~~~

docs/design/quick_filters.rst Outdated Show resolved Hide resolved
2. Twig template for rendering filter buttons
3. Array of PHP code for defining filter options

JavaScript functionality
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
JavaScript functionality
JavaScript features available

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it could be strange to talk about features (things that generate a possible action on the UI) when in fact we're talking about the gears from the system

what do you think?

docs/design/quick_filters.rst Outdated Show resolved Hide resolved
docs/design/quick_filters.rst Outdated Show resolved Hide resolved
docs/design/quick_filters.rst Outdated Show resolved Hide resolved
docs/design/quick_filters.rst Outdated Show resolved Hide resolved
docs/design/quick_filters.rst Outdated Show resolved Hide resolved
docs/design/quick_filters.rst Outdated Show resolved Hide resolved
@RCheesley RCheesley added documentation Improvements or additions to documentation pending-feedback labels Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation pending-feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants