msgconv,handewhatsapp: Bridge "Live photos" as GIFs #845
Conversation
are we only mapping the gif/live photo and discarding the regular one? it's better to map both since people will want to see the regular pic too |
Can you provide me with the structure of the normal photo? I am mapping both parent and child photos. Seems like the parent is the still image and the child is the motion version. |
What should happen is that the photo is bridged then edited to be a GIF |
|
for first iteration, we should leave the original intact and just map the child as a new gif message if possible (does this cause collisions?) |
This will cause a duplicated message, but sure I'll get it working that way, just requires removing some logic. |
Co-authored-by: Tulir Asokan <[email protected]>
| case *waE2E.VideoMessage: | ||
| data.MsgType = event.MsgVideo | ||
| if msg.GetGifPlayback() { | ||
| pairedMediaType := msg.GetContextInfo().GetPairedMediaType() |
There was a problem hiding this comment.
Hmm, is the context info inside the associated child message or outside? might need to copy it over if it's outside
There was a problem hiding this comment.
Oh, MessageContextInfo is outside, ContextInfo is of course inside. I don't think there's anything important in MessageContextInfo so this should be fine as is
Handles Live photos as a GIF and prevents attachment duplication.
Resolves BRI-33301