msgconv: fix view once placeholder copy when you send instead of receive #848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KishanBagaria
commented
Oct 5, 2025
| content := &undecryptableMessageContent | ||
| if evt.Type == events.UnavailableTypeViewOnce { | ||
| verb := "received" | ||
| if evt.Info.IsFromMe { |
Contributor
Author
There was a problem hiding this comment.
i forget if IsFromMe is always accurate, like would this be true if another device relayed us someone else's message?
Member
There was a problem hiding this comment.
It is always accurate, responses to message requests from phone are wrapped in a WebMessageInfo in order to have accurate event metadata
Member
|
I think that's not entirely accurate either, since you can't actually open your own view-once media. This is what native shows: 
|
Contributor
Author
|
good catch, updated the copy |
purpshell
reviewed
Oct 5, 2025
Co-authored-by: Rajeh Taher <[email protected]>
tulir
approved these changes
Oct 5, 2025
fru-9D
added a commit
to fru-9D/whatsapp
that referenced
this pull request
Oct 21, 2025
* chatinfo: flag group resyncs as excluded from timeline * handlematrix: implement account data interfaces * dependencies: update whatsmeow and set PostgresArrayWrapper properly * dependencies: update whatsmeow * dependencies: update whatsmeow * client: enable synchronous acks and decrypted event buffer for everyone * dependencies: update whatsmeow * client: disable decrypted event buffer * dependencies: update whatsmeow * msgconv: fix view once placeholder copy when you send instead of receive (mautrix#848) Co-authored-by: Rajeh Taher <[email protected]> * fixed issue in placeholders appearing when media sync is turned off --------- Co-authored-by: Tulir Asokan <[email protected]> Co-authored-by: Kishan Bagaria <[email protected]> Co-authored-by: Rajeh Taher <[email protected]> Co-authored-by: Faraz Haider <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.