Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generated code and takeoff example #71

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

dieguit
Copy link

@dieguit dieguit commented Apr 19, 2024

This PR adds generated rust files for every plugin, and allows access to the full grpc api with type safety.

Instead of manually writing rust code for every service, request and response, it exposes the client generated by tonic_build. Making the library unopinionated and 100% dependant on the grpc server definitions. I consider this approach more mantainable, as there is already some effort in the mavlink organization to keep the mavlink_server and it's proto files running correctly for other SDK wrappers.

I also added an example for takeoff and land, where multiple plugins are tested at the same time.

There have been previous discussions about using FFI, I did a quick test and I was not able to get the bindings working correctly, so if somebody with C++ experience wants to help, I'd be happy to try again.

@julianoes
Copy link
Collaborator

Wow, that's amazing! Thanks for your work. Looking forward to giving it a try.

@FilipPyrek
Copy link

FilipPyrek commented Jun 5, 2024

Great new PR! What about merging it? 😊

I'm trying to get to drones and Rust at the same time... and any improvements to this library are very helpful for me 🙂

@julianoes
Copy link
Collaborator

Right, I'm not really the maintainer here, so I was leaving it to @danieleades or @irsdkv to merge.

Also, CI seems to fail, so that's something to check before merging, I assume.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants