Add stepwise support #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/video/video_source_local.rs
Outdated
Comment on lines
209
to
224
| (7200, 3060), | ||
| (7680, 4320), | ||
| (3840, 2160), | ||
| (2560, 1440), | ||
| (1440, 1080), | ||
| (1920, 1080), | ||
| (1280, 1080), | ||
| (1600, 1200), | ||
| (1280, 720), | ||
| (1024, 768), | ||
| (960, 720), | ||
| (800, 600), | ||
| (640, 480), | ||
| (640, 360), | ||
| (320, 240), | ||
| (256, 144), |
There was a problem hiding this comment.
I've chosen to only add common and widely used resolutions as opposed to deciding resolutions algorithmically because I found it to be near impossible to balance the number of sizes with how useful they would actually be, every resolution from algorithms was looking random, like 1326x1768 for 4:3, and if we would be adding the standard ones, why should we even bother trying that...
patrickelectric
requested changes
Jun 21, 2022
src/video/video_source_local.rs
Outdated
| (3840, 2160), | ||
| (2560, 1440), | ||
| (1440, 1080), | ||
| (1920, 1080), |
There was a problem hiding this comment.
Needs sort, dedup and move this to a const.
|
some comments would also be nice. |
joaoantoniocardoso
force-pushed
the
add-stepwise-support
branch
from
7abb3c4
to
15472c5
Compare
patrickelectric
requested changes
Jul 7, 2022
joaoantoniocardoso
force-pushed
the
add-stepwise-support
branch
from
15472c5
to
1f7d222
Compare
joaoantoniocardoso
force-pushed
the
add-stepwise-support
branch
from
952ed71
to
18cec4c
Compare
joaoantoniocardoso
force-pushed
the
add-stepwise-support
branch
from
18cec4c
to
41829e3
Compare
patrickelectric
approved these changes
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is one step further to #66. Actually, with this implementation, the raspberry pi camera works in legacy mode, but more test is needed.