Some fixes I made #22
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Script was hugely rewritten. First rebase your patches. |
|
I know essentially 0 about git - I installed it to check this out so don't know exactly how to do that. I will give it a shot but more than likely I will fail utterly. |
|
I remerged those changes. should be able to pull them now... |
|
NB: I've merged Jeff's changes into my master @ https://github.com/tardate/mysql2postgres |
|
Thanks! |
|
Max - just checked and these changes are all in master and the released gem so you could close this pull request |
|
I cannot see when these commits would have landed... @tardate are you able to point them out? |
|
Closing as an old pull request, that would seem to be out of date. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made 3 bug fixes to mysql2postgres - fix handling floats (the current code would turn them into numeric(random#,0) where random# would be the most recent precision or length encountered in processing the schema, the second fix is to properly initialize length (I used -1 because an error on schema creation to guessing with the possible risk of truncating data).
The final change was to emit a warning when an COPY fails, I found that because of corrupted dates (things like 0000-12-00) there were errors in the copy - the code would happily and silently drop that chunk on insert. I changed the code to check count from res.cmdtuples and print a warning when it failed.
I tested this but only on mysql 5.1 and pg 9.0. the float fix is for bug 21 I booked.