form recovery: fix javascript error and the live view crashing #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`this.el.id` would require a hash ("#"), but it's better to pass the DOM
element since this is supported.
Fixes the following error in the web console on reconnect:
nothing found matching the phx-target selector "my_form_city_search_live_select_component"
Steps to reproduce this bug:
* Select a city in the LiveSelect
* Disconnect and reconnect the `liveSocket` to force form recovery
* Just click on the LiveSelect, the view will crash with:
** (KeyError) key :disabled not found in: %{label: "Rome", value: %{"name" => "Rome", "pos" => [12.51133, 41.89193]}}
(live_select 1.7.1) lib/live_select/component.html.heex:115: anonymous fn/3 in LiveSelect.Component.render/1
gmazzamuto
changed the title
|
Thank you!!! 🙏🚀🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.