fix: reject nil values in selection list #127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you so much for fixing this and for adding a test!!!! 🙏🚀🎉 |
|
Btw: unfortunately the error seems to still occur when you have an option selected :( To reproduce, select something and then follow the steps to reproduce #125. If you want to take a look you're very welcome, otherwise I'll take a look once I have some time. |
|
Ah, nice catch! I can definitely take another look when having some time. Thanks for the heads up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #125.
Hi.. thanks for the library, works great!
I started seeing this error here and there on our apps as well. So this is an attempt to fix it by rejecting nil values on the selection list. The added unit test reproduces the failure before the fix.