Account Activity View + Account Forms #1406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ccount-activity-view
…ccount-activity-view
…ccount-activity-view
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a complete overhaul of how we're displaying accounts to the user. This new view is based on extensive feedback we received by users in Discord and aims to make transactions + balances much more intuitive:
This PR also brings back the account type selector:
I've moved all "accountable" code to dedicated controllers and views as it was getting very challenging to implement "type specific" behaviors. We had previously shoved everything in
/app/views/accounts/accountableswhich was getting very messy and was implementing the "pseudo inheritance" of delegated types in the wrong direction (requiring subclasses to implement non-shared behavior vs. the opposite)