Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rails LSP plugin #253

Merged
merged 2 commits into from
Feb 2, 2024
Merged

Conversation

JoshAntBrown
Copy link
Contributor

This PR adds the ruby-lsp-rails gem in development.

It injects a Rack app into development on /ruby_lsp_rails/ so that the ruby-lsp can show attributes and types in your editor, should be useful for helping anyone new to the codebase get to grips with all the things that exist.

I've also updated the Gemfile to read the ruby version from .ruby-version, which reduces some duplication and makes it a little easier to upgrade the version in future.

Gemfile Outdated
@@ -1,6 +1,6 @@
source "https://rubygems.org"

ruby "3.3.0"
ruby File.read(".ruby-version").strip
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would ruby file: ".ruby-version" work?

Copy link
Contributor Author

@JoshAntBrown JoshAntBrown Feb 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would! Thanks, have just updated.

@Shpigford Shpigford merged commit a1c475d into maybe-finance:main Feb 2, 2024
3 of 4 checks passed
@JoshAntBrown JoshAntBrown deleted the add-rails-lsp branch February 2, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants