Centralize auth messages #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@josefarias Couple of conflicts that popped up from a PR merge this morning. |
JuanVqz
pushed a commit
to JuanVqz/maybe
that referenced
this pull request
Feb 5, 2024
* Add i18n-tasks * Add auth-related i18n * Centralize auth messages * Remove safe navigation * Revert "Remove safe navigation" This reverts commit 56b5e01. * Remove newline in Gemfile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #264
At first, I thought by "centralize" we meant we wanted all the copy for the messages in a single place for easy editing. So I added rudimentary i18n, as well as i18n-tasks, which helps keep i18n files tidy. (That's on me for not paying attention, sorry I jumped the gun here)
Then I realized we actually wanted the messages to all appear in a single place for auth-related forms, so I pulled out a helper for that, too.
Let me know if we don't want the i18n part of this. Happy to take it out.
To be clear, there's still plenty of i18n work left to do — this was more meant to organize the auth messages. The rest of the app needs to be configured still. We can tackle that work as part of #256.