Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [open-zaak/open-notificaties#156] Support nested fields on kanaal kenmerken #14

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

stevenbal
Copy link
Collaborator

@stevenbal stevenbal commented Aug 30, 2024

Related issue: open-zaak/open-notificaties#156

Requires zgw-consumers to be upgraded in Open Zaak

Changes:

  • Support nested fields on kanaal kenmerken

@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.21%. Comparing base (7abd32e) to head (68c8ba8).

Files with missing lines Patch % Lines
notifications_api_common/kanalen.py 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
- Coverage   89.23%   89.21%   -0.03%     
==========================================
  Files          29       29              
  Lines         604      612       +8     
==========================================
+ Hits          539      546       +7     
- Misses         65       66       +1     
Flag Coverage Δ
89.21% <93.33%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stevenbal stevenbal force-pushed the feature/kanaal-kenmerken-nested-fields branch 2 times, most recently from 3d1f4b7 to dfce6ea Compare September 26, 2024 14:22
@stevenbal stevenbal marked this pull request as draft September 26, 2024 14:23
@stevenbal stevenbal force-pushed the feature/kanaal-kenmerken-nested-fields branch 4 times, most recently from 410e968 to d0ea73e Compare September 27, 2024 12:18
…et_kenmerken

and add hook for `_get_field` to support nested attributes in Open Zaak
and clean up mock usage in other tests
@stevenbal stevenbal force-pushed the feature/kanaal-kenmerken-nested-fields branch from 64885ff to a1caa4c Compare October 24, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants