fixes

mazenrashed · Aug 9, 2021 · 7c38dad · 7c38dad
1 parent 0486400
commit 7c38dad
Show file tree

Hide file tree

Showing 7 changed files with 24 additions and 25 deletions.
diff --git a/.idea/codeStyles/Project.xml b/.idea/codeStyles/Project.xml
diff --git a/.idea/compiler.xml b/.idea/compiler.xml
diff --git a/.idea/gradle.xml b/.idea/gradle.xml
diff --git a/.idea/misc.xml b/.idea/misc.xml
diff --git a/...omSheetMenuLib/src/main/java/com/mazenrashed/bottomsheetmenulib/MenuBottomSheetAdapter.kt b/...omSheetMenuLib/src/main/java/com/mazenrashed/bottomsheetmenulib/MenuBottomSheetAdapter.kt
@@ -1,6 +1,7 @@
 package com.mazenrashed.bottomsheetmenulib
 
 import android.view.LayoutInflater
+import android.view.View
 import android.view.ViewGroup
 import com.mazenrashed.bottomsheetmenulib.base.BaseAdapter
 import com.mazenrashed.bottomsheetmenulib.base.BaseViewHolder
@@ -18,6 +19,8 @@ class MenuBottomSheetAdapter :
                 this.textView.text = item?.title
                 item?.iconRes?.let { this.icon.setImageResource(it) }
                 item?.iconDrawable?.let { this.icon.setImageDrawable(it) }
+                this.icon.visibility =
+                    if (item?.iconDrawable == null && item?.iconRes == null) View.GONE else View.VISIBLE
             }
         }
 

diff --git a/BottomSheetMenuLib/src/main/res/layout/bottom_sheet_menu.xml b/BottomSheetMenuLib/src/main/res/layout/bottom_sheet_menu.xml
@@ -25,11 +25,15 @@
     <androidx.recyclerview.widget.RecyclerView
         android:id="@+id/recycler_view"
         android:layout_width="0dp"
-        android:layout_height="wrap_content"
+        android:layout_height="match_parent"
         android:layout_marginTop="32dp"
+        android:clipToPadding="false"
+        android:paddingBottom="16dp"
         app:layoutManager="androidx.recyclerview.widget.LinearLayoutManager"
-        app:layout_constraintEnd_toEndOf="parent"
+        app:layout_constraintBottom_toBottomOf="parent"
+
         app:layout_constraintStart_toStartOf="parent"
+        app:layout_constraintEnd_toEndOf="parent"
         app:layout_constraintTop_toTopOf="parent"
         tools:listitem="@layout/bottom_sheet_menu_item" />
 

diff --git a/BottomSheetMenuLib/src/main/res/layout/bottom_sheet_menu_item.xml b/BottomSheetMenuLib/src/main/res/layout/bottom_sheet_menu_item.xml
@@ -5,15 +5,15 @@
         xmlns:app="http://schemas.android.com/apk/res-auto"
         xmlns:tools="http://schemas.android.com/tools"
         android:layout_width="match_parent"
-        android:layout_height="wrap_content">
+        android:layout_height="wrap_content"
+        android:paddingTop="8dp"
+        android:paddingBottom="8dp">
 
         <ImageView
             android:id="@+id/icon"
             android:layout_width="25dp"
             android:layout_height="25dp"
             android:layout_marginStart="16dp"
-            android:layout_marginTop="8dp"
-            android:layout_marginBottom="8dp"
             app:layout_constraintBottom_toBottomOf="parent"
             app:layout_constraintStart_toStartOf="parent"
             app:layout_constraintTop_toTopOf="parent"