Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add themes #402

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

add themes #402

wants to merge 6 commits into from

Conversation

Geezus42
Copy link

Description

Adding additional themes, mainly more Gruvbox variants.

Theme Submission Checklist

  • Included theme in iTerm2 format
  • Included 600x300 screenshot, 13pt Monaco font, no transparency
  • Updated README.md with new theme and screenshot
  • Updated CREDITS.md with new theme
  • Ran tools/gen.py to generate themes in all formats
  • Updated screenshots/README.md with new theme

@mbadolato
Copy link
Owner

Hi, thanks for the submission.

  • The screenshots for Gruvbox Dark, Gruvbox Material Dark and Hactober are missing,
  • The credits lists Gruvbox Material Dark twice and two different authors and is missing the other themes' credits
  • The screenshot files are not named correctly
  • All of the itermcolors files are names inconsistently, and most incorrectly
  • The Readme is missing some links
  • The screenshot in gruvbox-material-iterm2.png is not showing the text like the other themes in the repo
  • The tools.gen.py was not run to include all other formats

Can you please update? Thanks

@mbadolato
Copy link
Owner

ping @Geezus42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Geezus42 @mbadolato