Skip to content

Conversation

@sourcery-ai
Copy link

@sourcery-ai sourcery-ai bot commented Oct 31, 2022

Branch master refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the master branch, then run:

git fetch origin sourcery/master
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

@sourcery-ai sourcery-ai bot requested a review from chilango74 October 31, 2022 07:25
request_url = URL_BASE
resp = requests.get(request_url)
while ( not (resp.status_code == 200)):
while resp.status_code != 200:
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function get_data_frame refactored with the following changes:

  • Simplify logical expression using De Morgan identities (de-morgan)

@sourcery-ai
Copy link
Author

sourcery-ai bot commented Oct 31, 2022

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.10%.

Quality metrics Before After Change
Complexity 1.88 ⭐ 1.88 ⭐ 0.00
Method Length 88.00 🙂 87.50 🙂 -0.50 👍
Working memory 6.76 🙂 6.76 🙂 0.00
Quality 68.85% 🙂 68.95% 🙂 0.10% 👍
Other metrics Before After Change
Lines 34 34 0
Changed files Quality Before Quality After Quality Change
boe/request_data.py 68.85% 🙂 68.95% 🙂 0.10% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
boe/request_data.py get_data_frame 2 ⭐ 154 😞 7 🙂 67.12% 🙂 Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

fzhulitov added a commit that referenced this pull request Jan 12, 2023
Merge pull request #3 from fzhulitov/master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant