Skip to content

Conversation

@seppulcro
Copy link

@seppulcro seppulcro commented Oct 10, 2024

Hi, I've added the ability to cycle through panels infinitely, with an option do go through hidden panels as well.

Solves #686

output.webm

@seppulcro seppulcro force-pushed the feat/loop-cycle-panels branch from 9923dbc to 7f302df Compare October 10, 2024 16:00
@ChilledMoth
Copy link
Contributor

Nice, but why are you taking over the default hotkey for 'Open a new tab after the active tab'?

Just leave it undefined or set a new one, idk, 'Alt+M' or something (since 'Alt-Comma' and 'Alt+Period' are the defaults for 'Switch to previous panel' and 'Switch to next panel', respectively).

@seppulcro
Copy link
Author

Nice, but why are you taking over the default hotkey for 'Open a new tab after the active tab'?

Just leave it undefined or set a new one, idk, 'Alt+M' or something (since 'Alt-Comma' and 'Alt+Period' are the defaults for 'Switch to previous panel' and 'Switch to next panel', respectively).

Whoops sorry I've been using that since I've setup it up and must've forgot to change it back.

I've also noticed a typo that I've fixed, and since I started using it for myself yesterday the ability to go only forwards didn't seem enough... so I added the ability to go backwards too in the latest commit.

@seppulcro
Copy link
Author

@ChilledMoth please re-validate when you have the time so I know if it's up to spec now 😁

@llc0930
Copy link
Contributor

llc0930 commented Dec 19, 2024

I personally think this feature should be added as an optional setting rather than replacing the original setting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants