Skip to content

Conversation

@ErichDonGubler
Copy link

Satisfies #1991.

@ErichDonGubler
Copy link
Author

I think this is basically ready for review, disclaiming that I'm not familiar with the vast majority of the Sidebery codebase. I haven't brought it out of draft yet, though, because the premise of this feature hasn't been validated by maintainership (see #1991).

@mbnuqw
Copy link
Owner

mbnuqw commented Nov 15, 2025

Thanks, nice feature! Things that I'd change:

  • Create service omnibox.ts and move that code to it. Export one function setupListeners and call it in background.ts: omnibox.setupListeners().
  • Use different keyword, something easily accessible from other, non-latin keyboard layouts. e.g. = (it seems that this symbol is available in all supported locales (de, fr, hu, pl, ru, zh, ja) without switching to en layout, although I could be wrong).
  • Translate default suggestion

You can make it mergable and I'll complete it myself (prob also add switching between panels).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants