-
-
Notifications
You must be signed in to change notification settings - Fork 217
Add = omnibox handler, use it for reopening tabs in a different container
#1992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3f89a75 to
6fa0264
Compare
|
I think this is basically ready for review, disclaiming that I'm not familiar with the vast majority of the Sidebery codebase. I haven't brought it out of draft yet, though, because the premise of this feature hasn't been validated by maintainership (see #1991). |
49a6bac to
ea8ef1f
Compare
|
Thanks, nice feature! Things that I'd change:
You can make it mergable and I'll complete it myself (prob also add switching between panels). |
0e1860c to
678384a
Compare
|
I've applied each of your suggestions. There are still several |
sb omnibox handler, use it for reopening tabs in a different container= omnibox handler, use it for reopening tabs in a different container
| }) | ||
|
|
||
| function matchContainers(input: string): Container[] { | ||
| // TODO: order by score of some sort? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
todo: Any suggestions on what to do here?
7d4775e to
038c62f
Compare
|
Thanks
I though about sorting by the time of the last usage, but this will require adding logic for saving/loading info of the last N used commands. Too much for the initial implementation, so I think we can leave this as it is, a couple more of chars in the query will be enough for narrowing down the list of suggestions.
Not sure we need this right now, with only containers as the target. After all, containers usually have a different names? Later, when there will be more commands this can be added with the above mentioned sorting.
Not sure I understand this correctly. Sidebery mirrors the Firefox containers augmenting them with new features. |
244dc20 to
f0ed2e0
Compare
f0ed2e0 to
1bf6672
Compare
1bf6672 to
af74784
Compare
|
Thank you. Going to merge this.
Sorry, (probably didn't convey my thoughts well) I'll revert this as it will make impossible for Japanese and Chinese users to search for one/two-length names of containers (in hieroglyphs). Such limitations are usually added with the large lists of source data that is not our case. |
Satisfies #1991.