Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the previous pr #1608 for some reason stalled and was never merged.
i too am interested in seeing sidebery working under chrome :3
i picked up after them and rebased, though it seems as if most of the issues you raised in that pr have already been addressed
i only really updated the bg script to set up listeners in top-level to (hopefully) work correctly with mv3 event pages
a few open questions i still have:
runtime.onInstalledlistener" – haven't really changed anything there, but menus seem to be working fineif we're going the "chrome support" route, we'll eventually need to get rid of
webRequest/webRequestBlockingapi usages too.i don't entirely understand where they are currently used, seems like something related to containers..? if so, can probably be skipped for now as chrome doesn't have anything like that
will close #916