feat: make settings field labels selectable #2332
Open
+18
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FurkanKambay
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2275
I moved the mouse-down check from the whole field to only the input component so that clicking on the setting label won't interfere with text selection, as described in the issue.
One alternative approach which I'm not sure is possible: just mouse-down by itself on the field still modifies the setting, but hold-drag acts as text selection without modifying it. But honestly, even without considering the text selection stuff, I'd already prefer if clicking on the label didn't actually modify the setting.
Let me know if you'd like me to try to do that though.