Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: perform data error actions before forgetting them #530

Merged
merged 3 commits into from
Nov 12, 2024

Conversation

boringcactus
Copy link
Member

@boringcactus boringcactus commented Nov 8, 2024

Summary

Ticket: Investigate: Error banner appears often without obvious cause

I checked when these steps started being run in this order, and I wish I hadn't, because now I know that this bug has been present the whole time and it's my fault. Oh well.

Testing

Manually verified that in the new order data is actually refreshed.


@boringcactus boringcactus requested a review from a team as a code owner November 8, 2024 21:20
@boringcactus boringcactus merged commit 3c80f2e into main Nov 12, 2024
7 checks passed
@boringcactus boringcactus deleted the mth-fix-data-error branch November 12, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants