fix: ensure gradle knows pods are installed #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmmaSimon
reviewed
Nov 12, 2024
iosApp/ci_scripts/ci_post_clone.sh
Outdated
| @@ -63,6 +63,7 @@ retry ./gradlew :shared:generateDummyFramework | |||
| cd "${CI_PRIMARY_REPOSITORY_PATH}/iosApp" | |||
| retry bundle exec pod install | |||
| cd .. | |||
| retry ./gradlew :shared:podInstallSyntheticIos | |||
There was a problem hiding this comment.
Hmm, this seems to be failing because it can't find the pod install
Execution failed for task ':shared:podInstallSyntheticIos'.
> ERROR: CocoaPods executable not found in your PATH.
Please make sure CocoaPods is installed on your system.
Which is strange, since you can see the pod install complete directly above it. Could XCC be messing with the path somehow? Or could the dependency license changes have messed up gradle's path?
There was a problem hiding this comment.
When we install CocoaPods via Bundler, it's not actually on the PATH, and bundle exec rewrites the PATH to include all the gems it manages. It might be sufficient to put the Gradle task inside bundle exec, though.
EmmaSimon
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket: none
Builds on
mainare failing right now, and from the error message I think this is why.Testing
When I get the same error message locally, this is how I fix it, but I have no idea if it'll fix the non-test Xcode Cloud targets until we merge this (unless we want to temporarily add archive or analyze to the PR workflow).