RepairManager: Fix unsafe enchantments being stripped, CombatUtils: Use instanceof for IronGolem #5192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SrBedrock
reviewed
Jun 28, 2025
| @@ -883,8 +883,8 @@ public static void processCombatXP(@NotNull McMMOPlayer mcMMOPlayer, | |||
| EntityType type = target.getType(); | |||
|
|
|||
| if (ExperienceConfig.getInstance().hasCombatXP(type)) { | |||
| if (type == EntityType.IRON_GOLEM) { | |||
| if (!((IronGolem) target).isPlayerCreated()) { | |||
| if (type == EntityType.IRON_GOLEM && target instanceof IronGolem ironGolem) { | |||
There was a problem hiding this comment.
Couldn't it just be the instanceOf check here?
There was a problem hiding this comment.
Probably, I've added instance of check cause we saw cast exceptions flying. I'll check once I'm back, but I think you're right.
|
Thank you for the two fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RepairManager: Fix unsafe enchantments being stripped
CombatUtils: Use instanceof for IronGolem check to avoid cast exceptions for pets/npcs/...