Skip to content

fix(experience): parse diminished returns value from correct field #5196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2025

Conversation

TheBentoBox
Copy link
Contributor

ExperienceConfig was attempting to parse the min diminished returns value from a field named Dimished_Returns, while the field in the config is correctly named Diminished_Returns. This means that, with diminished returns enabled, the config field is essentially ignored and diminished returns always use the default 0.05.

This corrects the config to parse using the correct field name.

@nossr50 nossr50 merged commit f9513a8 into mcMMO-Dev:master Jul 11, 2025
1 check passed
@nossr50
Copy link
Member

nossr50 commented Jul 11, 2025

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants