fix: logo-alt broken when logo-href provided

Fixes quarto-dev#10251
mcanouil · Jul 8, 2024 · 3753d67 · 3753d67
1 parent 7185c4e
commit 3753d67
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/news/changelog-1.6.md b/news/changelog-1.6.md
@@ -17,6 +17,10 @@ All changes included in 1.6:
 - ([#10217](https://github.com/quarto-dev/quarto-cli/issues/10217)): Explicitly compute units for image dimensions in `typst` format when they're not given.
 - ([#10212](https://github.com/quarto-dev/quarto-cli/issues/10212)): Moves Pandoc variables to the function declaration for the default template.
 
+## Website
+
+- ([#10251](https://github.com/quarto-dev/quarto-cli/issues/10251)): EJS template for website now uses proper object to get alt text for logo.
+
 ## Engines
 
 ### `julia`

diff --git a/src/resources/projects/website/templates/sidebar.ejs b/src/resources/projects/website/templates/sidebar.ejs
@@ -36,7 +36,7 @@
     <div class="pt-lg-2 mt-2 <%= alignCss %> sidebar-header<%= sidebar.logo && sidebar.title ? ' sidebar-header-stacked' : '' %>">
     <% if (sidebar.logo) { %>
       <a href="<%- sidebar['logo-href'] || '/index.html' %>" class="sidebar-logo-link">
-      <img src="<%- sidebar.logo %>" alt="<%- navbar['logo-alt'] || '' %>" class="sidebar-logo py-0 d-lg-inline d-none"/>
+      <img src="<%- sidebar.logo %>" alt="<%- sidebar['logo-alt'] || '' %>" class="sidebar-logo py-0 d-lg-inline d-none"/>
       </a>
     <% } %>
     <% if (needsTools && toolsLocation === "logo") { %>
@@ -92,4 +92,4 @@
   <% } %>
 
 </nav>
-<div id="quarto-sidebar-glass" class="quarto-sidebar-collapse-item" data-bs-toggle="collapse" data-bs-target=".quarto-sidebar-collapse-item" ></div>
+<div id="quarto-sidebar-glass" class="quarto-sidebar-collapse-item" data-bs-toggle="collapse" data-bs-target=".quarto-sidebar-collapse-item" ></div>