-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contributed component Source_custom #1911
Open
pablogila
wants to merge
8
commits into
mccode-dev:main
Choose a base branch
from
pablogila:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@pablogila thanks, will have a look soonish. :-) Two things consider in the meantime:
|
Thanks for the feedback Peter! I will check and add some things, will let you know then :D |
…ucture; using tmax_multiplier and n_pulses parameters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
I noticed that the contributed component Source_pulsed, while very customisable, only simulates the very first pulse of the beam. This may be the desired behaviour for some use cases, but others may need to simulate more pulses.
I have created a new contributed component,
Source_pulsed_multiSource_custom, which simulates all expected pulses in the specified time interval. It is a modification of the previously mentioned Source_pulsed. All component parameters remain the same and the component documentation is up to date.Attached is a simple test instrument to demonstrate the proper behavior of the proposed component:
Source_pulsed_multi.zip
The output signal from the test instrument with the previous Source_pulsed component:

And the output signal with the new Source_pulsed_multi component:
