rasdaemon: Do't process Ampere specific error in the public code #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ampere specific error info and error handler need to included in HAVE_AMP_NS_DECODE macro. Signed-off-by: Ruidong Tian <[email protected]>
|
@winterddd Could you please add details about the problem we met in commit log, so that the maintainer will see why we need this patch. |
mchehab
requested changes
Jan 22, 2024
| @@ -207,6 +206,9 @@ int ras_arm_event_handler(struct trace_seq *s, | |||
| ev.psci_state = val; | |||
| trace_seq_printf(s, "\n psci_state: %d", ev.psci_state); | |||
|
|
|||
| #ifdef HAVE_AMP_NS_DECODE | |||
| int len = 0; | |||
|
|
|||
There was a problem hiding this comment.
Coding style nit: please keep all variable declarations at the beginning of the function.
| { .name="err_info", .type="BLOB" }, | ||
| { .name="context_info", .type="BLOB" }, | ||
| { .name="vendor_info", .type="BLOB" }, | ||
| #endif |
There was a problem hiding this comment.
Changing the DB format depending if those are declared or not sounds a bad idea, as if one recompiles the code with different options, the DB format will change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ampere specific error info and error handler need to included in HAVE_AMP_NS_DECODE macro.