rasdaemon: Fix mem_fail_event build breakage #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 566a526 ("add mem_fail_event trigger") introduces an event trigger for a memory failure event. However, if the rasdaemon is not configured with enable-memory-failure, the setup function of the trigger, mem_fail_event_trigger_setup(), will result in an undefined reference linker error when called through setup_event_trigger(). Ensure that the setup function for the trigger is called only when the rasdaemon has been configured with enable-memory-failure. Fixes: 566a526 ("add mem_fail_event trigger") Signed-off-by: Avadhut Naik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 566a526 ("add mem_fail_event trigger") introduces an event trigger for a memory failure event.
However, if the rasdaemon is not configured with enable-memory-failure, the setup function of the trigger, mem_fail_event_trigger_setup(), will result in an undefined reference linker error when called through setup_event_trigger().
Ensure that the setup function for the trigger is called only when the rasdaemon has been configured with enable-memory-failure.
Fixes: 566a526 ("add mem_fail_event trigger")