symbol: Fix base64_encode to correctly encode bytes above 0x7F #311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a bug in base64_encode() function that was incorrectly encoding bytes with the most-significant bit set in the second or third byte of a 3-byte group. This was due to the use of signed `char` types in the bit-shifting expressions resulting in signed-extension causing all of the bits of the previous bytes to be overwritten with 1's. This fixes the problem by first casting the values to `unsigned char` so that the bit-shift, which promotes the type to `int`, does not do signed-integer extension. This fixes the problem by first casting the values to `unsigned char` so that the bit-shift, which promotes the type to `int`, does not do signed-integer extension. Signed-off-by: Lewis Baker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug in base64_encode() function that was incorrectly encoding bytes with the most-significant bit set in the second or third byte of a 3-byte group.
This was due to the use of signed
chartypes in the bit-shifting expressions resulting in signed-extension causing all of the bits of the previous bytes to be overwritten with 1's.This fixes the problem by first casting the values to
unsigned charso that the bit-shift, which promotes the type toint, does not do signed-integer extension.This fixes the problem by first casting the values to
unsigned charso that the bit-shift, which promotes the type toint, does not do signed-integer extension.Fixes #310