-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tidy] Apply mdformat to markdown files #873
base: main
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
View the example dashboards of the current commit live on PyCafe ☕ 🚀Updated on: 2024-11-14 11:01:34 UTC Link: vizro-core/examples/dev/ Link: vizro-core/examples/scratch_dev |
[![License](https://img.shields.io/badge/license-Apache%202.0-blue.svg)](https://github.com/mckinsey/vizro/blob/main/LICENSE.md) | ||
[![Documentation](https://readthedocs.org/projects/vizro/badge/?version=stable)](https://vizro.readthedocs.io/) | ||
[![OpenSSF Best Practices](https://www.bestpractices.dev/projects/7858/badge)](https://www.bestpractices.dev/projects/7858) | ||
FIXME: maybe use two new lines between each [![Python version](https://img.shields.io/badge/python-3.9%20%7C%203.10%20%7C%203.11%20%7C%203.12%20%7C%203.13-blue.svg)](https://pypi.org/project/vizro/) [![PyPI version](https://badge.fury.io/py/vizro.svg)](https://badge.fury.io/py/vizro) [![License](https://img.shields.io/badge/license-Apache%202.0-blue.svg)](https://github.com/mckinsey/vizro/blob/main/LICENSE.md) [![Documentation](https://readthedocs.org/projects/vizro/badge/?version=stable)](https://vizro.readthedocs.io/) [![OpenSSF Best Practices](https://www.bestpractices.dev/projects/7858/badge)](https://www.bestpractices.dev/projects/7858) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stichbury I don't massively mind these being wrapped but it is a bit unreadable compared to before. If it's possible to fix without changing how they actually render on the github page then that would be great. Otherwise it's ok how it is. I made the same comment in a few places but may well have missed some.
Looks like we might need to disable |
Description
Initial step towards #719 which actually formats very little of our code and instead applies a general markdown linter across our whole repo. Code formatting will follow in a later PR.
I have played around with various
mdformat
options and plugins for quite a long time now and I still do not fully understand how it behaves, which make me feel a bit uneasy... But it did help catch several errors in our yaml and seems to have done a generally good job tidying things up.The most controversial change (which is responsible for 90% of the diff) is that I set
keep=no
to remove word wrapping. This is something I've wanted to do for a long time (just use word wrapping in your editor with whatever width you like) but I am not strongly wedded to it if others disagree. wdyt @stichbury?What needs to done still in this PR:
custom-components.md
doesn't get formatted @stichburyFIXME
points @stichburydiff
compared to the current version)Follow up work:
mdformat-ruff
ormdformat-black
orblacken-docs
(preference is in that order), ideally with good line length @antonymilne. Needs to work for{.python}
code blocksNotice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":