Skip to content
This repository has been archived by the owner on Mar 18, 2023. It is now read-only.

1.18.2 Backport | Ready to merge #112

Open
wants to merge 8 commits into
base: 1.19.x/QC-merge
Choose a base branch
from

Conversation

CADIndie
Copy link
Member

@CADIndie CADIndie commented Aug 8, 2022

Mostly done, few method issues left to fix and will be ready to be merged into a new branch once the main QC/MCXR merge is done.

@Sorenon
Copy link
Member

Sorenon commented Aug 8, 2022

You love to see it

@CADIndie CADIndie changed the title 1.18.2 Backport | Almost Ready 1.18.2 Backport | Ready to merge Aug 13, 2022
@gregdan3
Copy link

Unable to load MC due to all three components claiming to need Fabric installed, when it is? Looks like a bad version specifier, but I'm unsure.

For reference, I pulled my Core and Desktop binaries from your branch's last build, and Play from the main repo.

[17:20:17] [main/INFO]: Loading Minecraft 1.18.2 with Fabric Loader 0.14.9
[17:20:17] [main/WARN]: Mod resolution failed
[17:20:17] [main/INFO]: Immediate reason: [HARD_DEP_NO_CANDIDATE mcxr-core 0.3.0 {depends fabric @ [*]}, HARD_DEP_NO_CANDIDATE mcxr-core 0.3.0 {depends fabric @ [*]}, ROOT_FORCELOAD mcxr-core]
[17:20:17] [main/INFO]: Reason: [HARD_DEP mcxr-core 0.3.0 {depends fabric @ [*]}, HARD_DEP mcxr-desktop 0.4.0 {depends fabric @ [*]}, HARD_DEP mcxr-play 0.2.1 {depends fabric @ [*]}]
[17:20:17] [main/INFO]: Fix: add [add:fabric 1 ([(-?,?)])], remove [], replace []
[17:20:17] [main/ERROR]: Incompatible mod set!
net.fabricmc.loader.impl.FormattedException: Mod resolution encountered an incompatible mod set!
A potential solution has been determined:
	 - Install fabric, any version.
Unmet dependency listing:
	 - Mod '[MCXR] Core' (mcxr-core) 0.3.0 requires any version of fabric, which is missing!
	 - Mod '[MCXR] Desktop' (mcxr-desktop) 0.4.0 requires any version of fabric, which is missing!
	 - Mod '[MCXR] Play' (mcxr-play) 0.2.1 requires any version of fabric, which is missing!
	at net.fabricmc.loader.impl.FabricLoaderImpl.load(FabricLoaderImpl.java:190) ~[fabric-loader-0.14.9.jar:?]
	at net.fabricmc.loader.impl.launch.knot.Knot.init(Knot.java:148) ~[fabric-loader-0.14.9.jar:?]
	at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:68) [fabric-loader-0.14.9.jar:?]
	at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23) [fabric-loader-0.14.9.jar:?]
	at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?]
	at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) ~[?:?]
	at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?]
	at java.lang.reflect.Method.invoke(Method.java:568) ~[?:?]
	at org.multimc.onesix.OneSixLauncher.launchWithMainClass(OneSixLauncher.java:210) [NewLaunch.jar:?]
	at org.multimc.onesix.OneSixLauncher.launch(OneSixLauncher.java:245) [NewLaunch.jar:?]
	at org.multimc.EntryPoint.listen(EntryPoint.java:143) [NewLaunch.jar:?]
	at org.multimc.EntryPoint.main(EntryPoint.java:34) [NewLaunch.jar:?]
Process exited with code 1 (0x1).
Please note that usually neither the exit code, nor its description are enough to diagnose issues!
Always upload the entire log and not just the exit code.

Loading the game without any MCXR files works without issue, putting me in MC with Fabric loaded.

@CADIndie
Copy link
Member Author

Uh, we have this as a release version, are you sure you did not forget to add the Fabric API?

@gregdan3
Copy link

@CADIndie This was the issue; I didn't realize MultiMC was failing to get the Fabric API. My bad!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants