Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebAssembly:Exception.stack and option.traceStack and platform support #15954

Merged
merged 4 commits into from
Apr 24, 2022

Conversation

hamishwillee
Copy link
Collaborator

@hamishwillee hamishwillee commented Apr 22, 2022

  1. This adds support for WebAssembly:Exception.stack, and constructor WebAssembly:Exception constructor option option.traceStack.

    • These are NOT in the spec yet but they are in the explainer, they are intended to go into the spec and they have been implemented in Firefox, Chromium, node, and probably Safari
    • Because they are not in the spec I indicated non-standard - but perhaps I should just put as standard since things are heading that way? I decided not to so that I can add the spec link later when one exists.
  2. Support was added for this in chromium was added in version 95 : https://chromestatus.com/feature/4756734233018368

  3. Support was added in node for v8 9.5 which corresponds to v17.0.0 : https://v8.dev/blog/v8-release-95#webassembly

@github-actions github-actions bot added the data:js 📟 Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript label Apr 22, 2022
@hamishwillee hamishwillee changed the title WebAssembly:Exception.stack and option.traceStack and chromium updates WebAssembly:Exception.stack and option.traceStack and platform support Apr 22, 2022
@hamishwillee hamishwillee marked this pull request as ready for review April 22, 2022 05:05
}
},
"status": {
"experimental": false,
"standard_track": true,
"deprecated": false
}
},
"options_parameter_traceStack": {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note, it occurs to be that this is not necessary, as it is the only option so far. I included it because it is is non-spec. But even if we decide it is spec I'd keep it - since then other options have something to compare again. Up to you though.

Copy link
Collaborator

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is LGTM!

@queengooborg queengooborg merged commit 83828ff into mdn:main Apr 24, 2022
@hamishwillee hamishwillee deleted the wasm_except_stack branch April 24, 2022 23:07
@hamishwillee
Copy link
Collaborator Author

Thanks! Sorry this is coming in dribs and drabs - taking me a fair bit of time to get my head around it.

@queengooborg
Copy link
Collaborator

Not a problem! I'd say it's much easier to review a bunch of smaller PRs than it is to review one big PR as it is. ;)

queengooborg added a commit to queengooborg/browser-compat-data that referenced this pull request Oct 21, 2023
This PR updates and corrects version values for Safari (Desktop and iOS/iPadOS) for the `Exception.stack` member of the `WebAssembly` JavaScript builtin. The data comes from the [mdn-bcd-collector](https://mdn-bcd-collector.gooborg.com) project (v10.2.10).

_Check out the [collector's guide on how to review this PR](https://github.com/openwebdocs/mdn-bcd-collector#reviewing-bcd-changes)._

Tests Used: https://mdn-bcd-collector.gooborg.com/tests/javascript/builtins/WebAssembly/Exception/stack

Additional Notes: This was set to Safari 15.2 in mdn#15954, but I have not been able to confirm support.
Elchi3 pushed a commit that referenced this pull request Oct 23, 2023
#21061)

This PR updates and corrects version values for Safari (Desktop and iOS/iPadOS) for the `Exception.stack` member of the `WebAssembly` JavaScript builtin. The data comes from the [mdn-bcd-collector](https://mdn-bcd-collector.gooborg.com) project (v10.2.10).

_Check out the [collector's guide on how to review this PR](https://github.com/openwebdocs/mdn-bcd-collector#reviewing-bcd-changes)._

Tests Used: https://mdn-bcd-collector.gooborg.com/tests/javascript/builtins/WebAssembly/Exception/stack

Additional Notes: This was set to Safari 15.2 in #15954, but I have not been able to confirm support.
teoli2003 pushed a commit to teoli2003/browser-compat-data that referenced this pull request Oct 25, 2023
mdn#21061)

This PR updates and corrects version values for Safari (Desktop and iOS/iPadOS) for the `Exception.stack` member of the `WebAssembly` JavaScript builtin. The data comes from the [mdn-bcd-collector](https://mdn-bcd-collector.gooborg.com) project (v10.2.10).

_Check out the [collector's guide on how to review this PR](https://github.com/openwebdocs/mdn-bcd-collector#reviewing-bcd-changes)._

Tests Used: https://mdn-bcd-collector.gooborg.com/tests/javascript/builtins/WebAssembly/Exception/stack

Additional Notes: This was set to Safari 15.2 in mdn#15954, but I have not been able to confirm support.
Elchi3 pushed a commit to Elchi3/browser-compat-data that referenced this pull request Nov 14, 2023
mdn#21061)

This PR updates and corrects version values for Safari (Desktop and iOS/iPadOS) for the `Exception.stack` member of the `WebAssembly` JavaScript builtin. The data comes from the [mdn-bcd-collector](https://mdn-bcd-collector.gooborg.com) project (v10.2.10).

_Check out the [collector's guide on how to review this PR](https://github.com/openwebdocs/mdn-bcd-collector#reviewing-bcd-changes)._

Tests Used: https://mdn-bcd-collector.gooborg.com/tests/javascript/builtins/WebAssembly/Exception/stack

Additional Notes: This was set to Safari 15.2 in mdn#15954, but I have not been able to confirm support.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:js 📟 Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants