-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebAssembly:Exception.stack and option.traceStack
and platform support
#15954
Conversation
option.traceStack
and chromium updatesoption.traceStack
and platform support
} | ||
}, | ||
"status": { | ||
"experimental": false, | ||
"standard_track": true, | ||
"deprecated": false | ||
} | ||
}, | ||
"options_parameter_traceStack": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note, it occurs to be that this is not necessary, as it is the only option so far. I included it because it is is non-spec. But even if we decide it is spec I'd keep it - since then other options have something to compare again. Up to you though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this is LGTM!
Thanks! Sorry this is coming in dribs and drabs - taking me a fair bit of time to get my head around it. |
Not a problem! I'd say it's much easier to review a bunch of smaller PRs than it is to review one big PR as it is. ;) |
This PR updates and corrects version values for Safari (Desktop and iOS/iPadOS) for the `Exception.stack` member of the `WebAssembly` JavaScript builtin. The data comes from the [mdn-bcd-collector](https://mdn-bcd-collector.gooborg.com) project (v10.2.10). _Check out the [collector's guide on how to review this PR](https://github.com/openwebdocs/mdn-bcd-collector#reviewing-bcd-changes)._ Tests Used: https://mdn-bcd-collector.gooborg.com/tests/javascript/builtins/WebAssembly/Exception/stack Additional Notes: This was set to Safari 15.2 in mdn#15954, but I have not been able to confirm support.
#21061) This PR updates and corrects version values for Safari (Desktop and iOS/iPadOS) for the `Exception.stack` member of the `WebAssembly` JavaScript builtin. The data comes from the [mdn-bcd-collector](https://mdn-bcd-collector.gooborg.com) project (v10.2.10). _Check out the [collector's guide on how to review this PR](https://github.com/openwebdocs/mdn-bcd-collector#reviewing-bcd-changes)._ Tests Used: https://mdn-bcd-collector.gooborg.com/tests/javascript/builtins/WebAssembly/Exception/stack Additional Notes: This was set to Safari 15.2 in #15954, but I have not been able to confirm support.
mdn#21061) This PR updates and corrects version values for Safari (Desktop and iOS/iPadOS) for the `Exception.stack` member of the `WebAssembly` JavaScript builtin. The data comes from the [mdn-bcd-collector](https://mdn-bcd-collector.gooborg.com) project (v10.2.10). _Check out the [collector's guide on how to review this PR](https://github.com/openwebdocs/mdn-bcd-collector#reviewing-bcd-changes)._ Tests Used: https://mdn-bcd-collector.gooborg.com/tests/javascript/builtins/WebAssembly/Exception/stack Additional Notes: This was set to Safari 15.2 in mdn#15954, but I have not been able to confirm support.
mdn#21061) This PR updates and corrects version values for Safari (Desktop and iOS/iPadOS) for the `Exception.stack` member of the `WebAssembly` JavaScript builtin. The data comes from the [mdn-bcd-collector](https://mdn-bcd-collector.gooborg.com) project (v10.2.10). _Check out the [collector's guide on how to review this PR](https://github.com/openwebdocs/mdn-bcd-collector#reviewing-bcd-changes)._ Tests Used: https://mdn-bcd-collector.gooborg.com/tests/javascript/builtins/WebAssembly/Exception/stack Additional Notes: This was set to Safari 15.2 in mdn#15954, but I have not been able to confirm support.
This adds support for
WebAssembly:Exception.stack
, and constructorWebAssembly:Exception
constructor optionoption.traceStack
.Support was added for this in chromium was added in version 95 : https://chromestatus.com/feature/4756734233018368
Support was added in node for v8 9.5 which corresponds to v17.0.0 : https://v8.dev/blog/v8-release-95#webassembly