Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox 105 supports api.OffscreenCanvas.getContext.webgpu_context #23706

Conversation

queengooborg
Copy link
Collaborator

@queengooborg queengooborg commented Jul 8, 2024

This PR updates and corrects version values for Firefox and Safari for the getContext.webgpu_context member of the OffscreenCanvas API. The data comes from the mdn-bcd-collector project (v10.11.0).

Check out the collector's guide on how to review this PR.

Tests Used: https://mdn-bcd-collector.gooborg.com/tests/api/OffscreenCanvas/getContext/webgpu_context

This PR updates and corrects version values for Firefox and Firefox Android for the `getContext.webgpu_context` member of the `OffscreenCanvas` API. The data comes from the [mdn-bcd-collector](https://mdn-bcd-collector.gooborg.com) project (v10.11.0).

_Check out the [collector's guide on how to review this PR](https://github.com/openwebdocs/mdn-bcd-collector#reviewing-bcd-changes)._

Tests Used: https://mdn-bcd-collector.gooborg.com/tests/api/OffscreenCanvas/getContext/webgpu_context
@queengooborg queengooborg added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Jul 8, 2024
@queengooborg queengooborg changed the title Update Firefox data for api.OffscreenCanvas.getContext.webgpu_context Update Firefox/Safari data for api.OffscreenCanvas.getContext.webgpu_context Jul 8, 2024
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the api/GPU*.json files, I'm skeptical about this change. I don't think it has shipped in Firefox/Safari stable yet.

Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot added the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label Jul 23, 2024
@queengooborg
Copy link
Collaborator Author

Screenshot 2024-07-23 at 00 36 46

Hmm, in Safari, it seems like it is actually supported in worker contexts...? Possibly a case of early exposure?

@Elchi3
Copy link
Member

Elchi3 commented Jul 23, 2024

Possibly accidental early expose on workers, yes. cc @jdatapple

@github-actions github-actions bot removed the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label Sep 8, 2024
@@ -395,7 +395,7 @@
},
"edge": "mirror",
"firefox": {
"version_added": "preview",
"version_added": "105",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

api/OffscreenCanvas.json Outdated Show resolved Hide resolved
@caugner caugner added the meeting agenda 🏢 Issues or pull requests in need of discussion in a project meeting. label Oct 25, 2024
Co-authored-by: Claas Augner <[email protected]>
@caugner caugner changed the title Update Firefox/Safari data for api.OffscreenCanvas.getContext.webgpu_context Firefox 105 supports api.OffscreenCanvas.getContext.webgpu_context Nov 5, 2024
@caugner caugner merged commit 102c108 into mdn:main Nov 5, 2024
6 checks passed
@queengooborg queengooborg deleted the api/OffscreenCanvas/getContext/webgpu_context/firefox-corrections branch November 5, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API meeting agenda 🏢 Issues or pull requests in need of discussion in a project meeting.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants