Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance(scripts/diff-features): improve performance #24974

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

enhance(scripts/diff-features): improve performance #24974

wants to merge 2 commits into from

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Nov 6, 2024 •
edited
Loading

Summary

Improves the performance of the diff-features script (used by the release script):

  1. Only fetch the workflow run for the head_sha we're looking for.
  2. Fetch changes asynchronously.

Test results and supporting details

Ran time npm run release -- --simulate before and after:

# Before
8.60s user 3.49s system 9% cpu 2:08.19 total

# After
7.26s user 3.28s system 44% cpu 23.535 total

Related issues

@github-actions github-actions bot added infra 🏗️ Infrastructure issues (npm, GitHub Actions, releases) of this project scripts 📜 Issues or pull requests regarding the scripts in scripts/. labels Nov 6, 2024
@caugner caugner mentioned this pull request Nov 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@queengooborg queengooborg Awaiting requested review from queengooborg

Assignees
No one assigned
Labels
infra 🏗️ Infrastructure issues (npm, GitHub Actions, releases) of this project scripts 📜 Issues or pull requests regarding the scripts in scripts/.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@caugner