Add spec_url for SVGAnimationElement
#25393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
data:api
yashrajbharti
suggested changes
Dec 12, 2024
| @@ -230,6 +233,7 @@ | |||
| }, | |||
| "endElementAt": { | |||
| "__compat": { | |||
| "spec_url": "https://svgwg.org/specs/animations/#__svg__SVGAnimationElement__endElementAt", | |||
There was a problem hiding this comment.
Suggested change
| "spec_url": "https://svgwg.org/specs/animations/#__svg__SVGAnimationElement__endElementAt", | |
| "mdn_url": "https://developer.mozilla.org/en-US/docs/Web/API/SVGAnimationElement/endElementAt", | |
| "spec_url": "https://svgwg.org/specs/animations/#__svg__SVGAnimationElement__endElementAt", |
| @@ -329,6 +333,7 @@ | |||
| }, | |||
| "getCurrentTime": { | |||
| "__compat": { | |||
| "spec_url": "https://svgwg.org/specs/animations/#__svg__SVGAnimationElement__getCurrentTime", | |||
There was a problem hiding this comment.
Suggested change
| "spec_url": "https://svgwg.org/specs/animations/#__svg__SVGAnimationElement__getCurrentTime", | |
| "mdn_url": "https://developer.mozilla.org/en-US/docs/Web/API/SVGAnimationElement/getCurrentTime", | |
| "spec_url": "https://svgwg.org/specs/animations/#__svg__SVGAnimationElement__getCurrentTime", |
| @@ -371,6 +376,7 @@ | |||
| }, | |||
| "getSimpleDuration": { | |||
| "__compat": { | |||
| "spec_url": "https://svgwg.org/specs/animations/#__svg__SVGAnimationElement__getSimpleDuration", | |||
There was a problem hiding this comment.
Suggested change
| "spec_url": "https://svgwg.org/specs/animations/#__svg__SVGAnimationElement__getSimpleDuration", | |
| "mdn_url": "https://developer.mozilla.org/en-US/docs/Web/API/SVGAnimationElement/getSimpleDuration", | |
| "spec_url": "https://svgwg.org/specs/animations/#__svg__SVGAnimationElement__getSimpleDuration", |
| @@ -413,6 +419,7 @@ | |||
| }, | |||
| "getStartTime": { | |||
| "__compat": { | |||
| "spec_url": "https://svgwg.org/specs/animations/#__svg__SVGAnimationElement__getStartTime", | |||
There was a problem hiding this comment.
Suggested change
| "spec_url": "https://svgwg.org/specs/animations/#__svg__SVGAnimationElement__getStartTime", | |
| "mdn_url": "https://developer.mozilla.org/en-US/docs/Web/API/SVGAnimationElement/getStartTime", | |
| "spec_url": "https://svgwg.org/specs/animations/#__svg__SVGAnimationElement__getStartTime", |
| @@ -188,6 +190,7 @@ | |||
| }, | |||
| "endElement": { | |||
| "__compat": { | |||
| "spec_url": "https://svgwg.org/specs/animations/#__svg__SVGAnimationElement__endElement", | |||
There was a problem hiding this comment.
Suggested change
| "spec_url": "https://svgwg.org/specs/animations/#__svg__SVGAnimationElement__endElement", | |
| "mdn_url": "https://developer.mozilla.org/en-US/docs/Web/API/SVGAnimationElement/endElement", | |
| "spec_url": "https://svgwg.org/specs/animations/#__svg__SVGAnimationElement__endElement", |
| @@ -89,6 +90,7 @@ | |||
| }, | |||
| "beginElementAt": { | |||
| "__compat": { | |||
| "spec_url": "https://svgwg.org/specs/animations/#__svg__SVGAnimationElement__beginElementAt", | |||
There was a problem hiding this comment.
Suggested change
| "spec_url": "https://svgwg.org/specs/animations/#__svg__SVGAnimationElement__beginElementAt", | |
| "mdn_url": "https://developer.mozilla.org/en-US/docs/Web/API/SVGAnimationElement/beginElementAt", | |
| "spec_url": "https://svgwg.org/specs/animations/#__svg__SVGAnimationElement__beginElementAt", |
| @@ -47,6 +47,7 @@ | |||
| }, | |||
| "beginElement": { | |||
| "__compat": { | |||
| "spec_url": "https://svgwg.org/specs/animations/#__svg__SVGAnimationElement__beginElement", | |||
There was a problem hiding this comment.
Suggested change
| "spec_url": "https://svgwg.org/specs/animations/#__svg__SVGAnimationElement__beginElement", | |
| "mdn_url": "https://developer.mozilla.org/en-US/docs/Web/API/SVGAnimationElement/beginElement", | |
| "spec_url": "https://svgwg.org/specs/animations/#__svg__SVGAnimationElement__beginElement", |
the mdn_url will automatically added when the mdn content docs added via this workflow, so it doesn't need to mantually add these and since these PRs havn't got merged yet, it is better not to add mdn_urls now |
caugner
approved these changes
Dec 13, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test results and supporting details
Related issues
Fixes #25384