Skip to content

Conversation

@dotproto
Copy link
Contributor

@dotproto dotproto commented Mar 10, 2025

Summary

This PR addresses the following feedback raised in another PR.

@rebloor can we add a note stating Firefox does not support generating a service_worker based in the scripts key? This is something currently only supported by Apple.

Originally posted by @carlosjeurissen in #25808 (comment)

Test results and supporting details

N/A

Related issues

@github-actions github-actions bot added the data:webext Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions label Mar 10, 2025
@github-actions github-actions bot added the size:s [PR only] 7-24 LoC changed label Mar 10, 2025
@rebloor
Copy link
Contributor

rebloor commented Mar 10, 2025

@dotproto but Firefox doesn't support service workers anyway, so why would there be an expectation that it would generate a background service worker? I think this note could be potentially confusing. Also, we provide more comprehensive information on the manifest key page: https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/background#browser_support

@github-actions github-actions bot added the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label Mar 10, 2025
@github-actions
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot removed the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label Mar 10, 2025
@caugner caugner requested a review from rebloor March 11, 2025 15:15
@carlosjeurissen
Copy link
Contributor

The current wording implies firefox would auto-generate a background service worker if scripts and preferred_environment are not specified in background. However Firefox simply never auto-generates a serviceWorker and only loads a serviceWorker if set explicitly in background.service_worker and serviceWorkers are enabled in the browser.

@carlosjeurissen
Copy link
Contributor

@rebloor Safari does auto generate a service worker. However this is not common knowledge and the current wording in this PR indeed causes more confusion than it removes.

@rebloor
Copy link
Contributor

rebloor commented Jun 2, 2025

@dotproto have you had a chance to review the feedback?

@rebloor
Copy link
Contributor

rebloor commented Aug 20, 2025

Supercedeed by mdn/content#40825

@rebloor rebloor closed this Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data:webext Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions size:s [PR only] 7-24 LoC changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants