Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify auto-generation of background service worker #26164

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dotproto
Copy link
Collaborator

@dotproto dotproto commented Mar 10, 2025

Summary

This PR addresses the following feedback raised in another PR.

@rebloor can we add a note stating Firefox does not support generating a service_worker based in the scripts key? This is something currently only supported by Apple.

Originally posted by @carlosjeurissen in #25808 (comment)

Test results and supporting details

N/A

Related issues

@github-actions github-actions bot added the data:webext Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions label Mar 10, 2025
@github-actions github-actions bot added the size:s [PR only] 7-24 LoC changed label Mar 10, 2025
@rebloor
Copy link
Contributor

rebloor commented Mar 10, 2025

@dotproto but Firefox doesn't support service workers anyway, so why would there be an expectation that it would generate a background service worker? I think this note could be potentially confusing. Also, we provide more comprehensive information on the manifest key page: https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/background#browser_support

@github-actions github-actions bot added the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label Mar 10, 2025
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot removed the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label Mar 10, 2025
@caugner caugner requested a review from rebloor March 11, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:webext Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions size:s [PR only] 7-24 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants