Skip to content

Update MediaStreamTrackProcessor spec_url and Chrome notes #26519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jan-ivar
Copy link
Contributor

@jan-ivar jan-ivar commented Apr 16, 2025

Summary

  • Have MediaStreamTrackProcessor members inherit partial support in chrome, for visibility
  • Add mdn links to VideoTrackGenerator

Test results and supporting details

npm test verified JSON, but complains of missing mdn links for VideoTrackGenerator (coming in mdn/content#39124).

couldn't get npm run stats to work, so hopefully things look OK.

Spec: https://w3c.github.io/mediacapture-transform/

@github-actions github-actions bot added data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API size:s [PR only] 7-24 LoC changed labels Apr 16, 2025
@caugner
Copy link
Contributor

caugner commented Apr 16, 2025

npm test verified JSON, but complains of missing mdn links for VideoTrackGenerator (coming in mdn/content#39124).

Note: We don't add mdn_urls to BCD before the corresponding pages are in content. Once a page with browser-compat frontmatter lands, the mdn_url field of the referenced BCD feature will be populated automatically (cf. this commit).

Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make the notes more concise.

Did you want to add similar notes to VideoTrackGenerator?

jan-ivar and others added 2 commits April 16, 2025 11:06
@jan-ivar
Copy link
Contributor Author

Did you want to add similar notes to VideoTrackGenerator?

No, since Chrome does not implement VideoTrackGenerator. When they do it will hopefully be on DedicatedWorker.

@caugner caugner changed the title Update MediaStreamTrackProcessor and VideoTrackGenerator Update MediaStreamTrackProcessor spec_url and Chrome notes Apr 18, 2025
@caugner caugner added the meeting agenda Issues or pull requests in need of discussion in a project meeting. label Apr 18, 2025
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spec defines exposure on the interface, not on its members, so I don't think it's right to set partial_implementation: true on the members, especially not on the readable property.

I acknowledge that it can be confusing that this limitation is not visible on the MediaStreamTrackProcessor constructor page, but I don't think updating the data like this is the right approach. Instead, I'm thinking that the BCD tables on MDN could include rows for the parent feature, while highlighting the feature corresponding to the current page.

I added this issue to the agenda of the next BCD meeting, so that we decide how to proceed.

@caugner
Copy link
Contributor

caugner commented Apr 22, 2025

I added this issue to the agenda of the next BCD meeting, so that we decide how to proceed.

We discussed this in today's BCD meeting, and for now we accept (but don't require) partial_implementation: true on the constructor in this case, but not on the other members (here: readable).

Comment on lines +92 to +94
"version_added": "94",
"partial_implementation": true,
"notes": "Exposed on `Window` instead of `DedicatedWorker`."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"version_added": "94",
"partial_implementation": true,
"notes": "Exposed on `Window` instead of `DedicatedWorker`."
"version_added": "94"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API meeting agenda Issues or pull requests in need of discussion in a project meeting. size:s [PR only] 7-24 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants