Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getPropertyValue differs from specified #36717

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

theking2
Copy link

Description

getPropertyValue results might differ from declared valurs

Motivation

Important if compairing values

Additional details

Related issues and pull requests

@theking2 theking2 requested a review from a team as a code owner November 10, 2024 14:05
@theking2 theking2 requested review from wbamberg and removed request for a team November 10, 2024 14:05
@github-actions github-actions bot added Content:WebAPI Web API docs size/s [PR only] 6-50 LoC changed labels Nov 10, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

github-actions bot commented Nov 15, 2024

Preview URLs

(comment last updated: 2025-01-08 21:58:48)

Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! I think this would be better in the main preamble bit (i.e. just before the ## Syntax heading) than as a standalone example, because it introduces new information, rather than illustrating information previously given. So I would have something like this:

Note that the string returned from this function may not use the same format as the authored string. For example, an authored value of color: hsl(250 90 50) will result in a returned value of rgb(51, 13, 242).

@bsmth bsmth added the awaiting response Awaiting for author to address review/feedback label Dec 31, 2024
@Josh-Cena Josh-Cena requested a review from wbamberg January 2, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting response Awaiting for author to address review/feedback Content:WebAPI Web API docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants