New pages: DOMMatrixReadOnly.skewX/skewY/rotate #37152

estelle · 2024-12-09T19:50:35Z

github-actions · 2024-12-09T19:52:47Z

Preview URLs (9 pages)

Flaws (10)

Note! 3 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/DOMMatrix/scale3dSelf
Title: DOMMatrix: scale3dSelf() method
Flaw count: 2

macros:
- /en-US/docs/Web/API/DOMMatrixReadOnly/is2D does not exist
- /en-US/docs/Web/API/DOMMatrix/scaleSelf does not exist

URL: /en-US/docs/Web/API/DOMMatrix/rotateFromVectorSelf
Title: DOMMatrix: rotateFromVectorSelf() method
Flaw count: 2

macros:
- /en-US/docs/Web/API/DOMMatrixRead/rotateSelf does not exist
- /en-US/docs/Web/API/DOMMatrixRead/rotateAxisAngleSelf does not exist

URL: /en-US/docs/Web/API/DOMMatrix/rotateAxisAngleSelf
Title: DOMMatrix: rotateAxisAngleSelf() method
Flaw count: 2

macros:
- /en-US/docs/Web/API/DOMMatrix/is2d does not exist
- /en-US/docs/Web/API/DOMMatrix/is2d does not exist

URL: /en-US/docs/Web/API/DOMMatrixReadOnly/skewY
Title: DOMMatrixReadOnly: skewY() method
Flaw count: 1

macros:
- /en-US/docs/Web/API/DOMMatrix/skewY does not exist

URL: /en-US/docs/Web/API/DOMMatrixReadOnly/rotateAxisAngle
Title: DOMMatrixReadOnly: rotateAxisAngle() method
Flaw count: 2

macros:
- /en-US/docs/Web/API/DOMMatrixReadOnly/is2D does not exist
- /en-US/docs/Web/API/DOMMatrixReadOnly/is2D does not exist

URL: /en-US/docs/Web/API/DOMMatrixReadOnly/skewX
Title: DOMMatrixReadOnly: skewX() method
Flaw count: 1

macros:
- /en-US/docs/Web/API/DOMMatrix/skewX does not exist

(comment last updated: 2025-01-12 03:01:28)

wbamberg

There were a few comment which applied to most of these pages, that I didn't note everywhere:

consider pretty-printing comments (and try to keep tgem under 80 characters, or they get hard-wrapped)
I'm not sure how relevant the CSS "see also" links are.

wbamberg · 2025-01-08T22:52:14Z

files/en-us/web/api/dommatrix/rotateaxisangleself/index.md

+The `rotateAxisAngleSelf()` method of the {{domxref("DOMMatrix")}} interface is a transformation method that returns a new {{domxref("DOMMatrix")}} created by rotating the source matrix by the given vector and angle. The original matrix is not altered.
+
+To rotate a matrix without mutating it, see {{domxref("DOMMatrix.rotateAxisAngleSelf()")}}


This sentence and the last sentence of the previous para seems wrong?

wbamberg · 2025-01-08T22:53:09Z

files/en-us/web/api/dommatrix/rotateaxisangleself/index.md

+  - : A number; the y-coordinate of the vector denoting the axis of rotation. If undefined, the `rotX` value is used. If non-zero, [`is2D`](/en-US/docs/Web/API/DOMMatrix#is2d) is false.
+- `rotZ` {{optional_inline}}
+  - : A number; the z-coordinate of the vector denoting the axis of rotation. If undefined, the `rotX` value is used. If non-zero, [`is2D`](/en-US/docs/Web/API/DOMMatrix#is2d) is false.
+- `angle` {{optional_inline}}
+  - : A number; the angle of the rotation around the axis vector, in degrees.


Spec suggests that is it x and y that affect is2D:

If x or y are not 0 or -0, set is 2D of the current matrix to false.

wbamberg · 2025-01-08T22:53:59Z

files/en-us/web/api/dommatrix/rotateaxisangleself/index.md

+// "matrix3d(0.728, 0.609, -0.315, 0, -0.525, 0.791, 0.315, 0, 0.441, -0.063, 0.895, 0, 0, 0, 0, 1)"
+console.log(matrix.toString());
+// "matrix3d(0.728, 0.609, -0.315, 0, -0.525, 0.791, 0.315, 0, 0.441, -0.063, 0.895, 0, 0, 0, 0, 1)"


Might be worth pretty-printing these comments so they are more readable.

wbamberg · 2025-01-09T00:13:20Z

files/en-us/web/api/dommatrix/rotateaxisangleself/index.md

+- CSS {{cssxref("transform")}} property
+- CSS {{cssxref("rotate")}} property
+- CSS {{cssxref("transform-function")}} functions
+  - {{cssxref("transform-function/rotate", "rotate()")}}
+  - {{cssxref("transform-function/rotate3d", "rotate3d()")}}
+  - {{cssxref("transform-function/rotateX", "rotateX()")}}
+  - {{cssxref("transform-function/rotateY", "rotateY()")}}
+  - {{cssxref("transform-function/rotateZ", "rotateZ()")}}
+- [CSS transforms](/en-US/docs/Web/CSS/CSS_transforms) module
+- SVG [`transform`](/en-US/docs/Web/SVG/Attribute/transform) attribute
+- {{domxref("CanvasRenderingContext2D")}} interface methods
+  - {{domxref("CanvasRenderingContext2D.rotate()")}}
+  - {{domxref("CanvasRenderingContext2D.transform()")}}
+  - {{domxref("CanvasRenderingContext2D.setTransform()")}}
+  - {{domxref("CanvasRenderingContext2D.resetTransform()")}}


I'm not that clear what the relevance of these transform/rotate pages are to this method. I mean it's not like you need to use matrices to rotate an item in CSS.

wbamberg · 2025-01-09T01:11:01Z

files/en-us/web/api/dommatrix/rotatefromvectorself/index.md

+
+{{APIRef("Geometry Interfaces")}}{{AvailableInWorkers}}
+
+The `rotateFromVectorSelf()` method of the {{domxref("DOMMatrix")}} interface is a mutable transformation method that modifies a matrix. It modifies the matrix by rotating the matrix by the angle between the specified vector and `(1, 0)`. The rotation angle is determined by the angle between the vector `(1,0)T` and `(x,y)T` in the clockwise direction, or `(+/-)arctan(y/x)`. If `x` and `y` are both `0`, the angle is specified as `0`, returning the altered {{domxref("DOMMatrix")}}.


The first sentence here isn't ideal because it doesn't say what the method does, just that it mutates the matrix. Better to combine the first two sentences, something like:

The rotateFromVectorSelf() method of the {{domxref("DOMMatrix")}} modifies the matrix by rotating the matrix by the angle between the specified vector and (1, 0).

The last sentence here "If x and y are both 0, the angle is specified as 0, returning the altered {{domxref("DOMMatrix")}}." is strange because if the angle is 0 isn't the matrix unchanged? So how can it be "altered"?

wbamberg · 2025-01-09T04:13:17Z

files/en-us/web/api/dommatrixreadonly/scale3d/index.md

+The **`scale3d()`** method of the {{domxref("DOMMatrixReadOnly")}} interface creates a new matrix being the result of the 3D scale transform being applied
+to the matrix. It returns a new {{domxref("DOMMatrix")}} created by scaling the source 3d matrix by the given scale factor centered on the origin point specified by the origin parameters, with a default origin of `(0, 0, 0)`. The original matrix is not modified.
+
+To mutate the matrix as you 3D-rotate it, see {{domxref("DOMMatrix.scale3dSelf()")}}


Suggested change

To mutate the matrix as you 3D-rotate it, see {{domxref("DOMMatrix.scale3dSelf()")}}

To mutate the matrix as you 3D-scale it, see {{domxref("DOMMatrix.scale3dSelf()")}}.

wbamberg · 2025-01-09T04:14:29Z

files/en-us/web/api/dommatrixreadonly/skewx/index.md

+
+{{APIRef("Geometry Interfaces")}}{{AvailableInWorkers}}
+
+The `skewX()` method of the {{domxref("DOMMatrixReadOnly")}} interface is a transformation method that returns a new {{domxref("DOMMatrix")}} created by applying the specified skew transformation to the source matrix along its X-axis. The original matrix is not modified.


Suggested change

The `skewX()` method of the {{domxref("DOMMatrixReadOnly")}} interface is a transformation method that returns a new {{domxref("DOMMatrix")}} created by applying the specified skew transformation to the source matrix along its X-axis. The original matrix is not modified.

The `skewX()` method of the {{domxref("DOMMatrixReadOnly")}} interface returns a new {{domxref("DOMMatrix")}} created by applying the specified skew transformation to the source matrix along its X-axis. The original matrix is not modified.

Also, "X axis" or X-axis"? (or x-axis or x axis). Below you have X axis.

wbamberg · 2025-01-09T04:14:47Z

files/en-us/web/api/dommatrixreadonly/skewx/index.md

+
+The `skewX()` method of the {{domxref("DOMMatrixReadOnly")}} interface is a transformation method that returns a new {{domxref("DOMMatrix")}} created by applying the specified skew transformation to the source matrix along its X-axis. The original matrix is not modified.
+
+To mutate the matrix as you skew it along the X-axis, see {{domxref("DOMMatrix.skewXSelf()")}}


Suggested change

To mutate the matrix as you skew it along the X-axis, see {{domxref("DOMMatrix.skewXSelf()")}}

To mutate the matrix as you skew it along the X-axis, see {{domxref("DOMMatrix.skewXSelf()")}}.

wbamberg · 2025-01-09T04:15:44Z

files/en-us/web/api/dommatrixreadonly/skewy/index.md

+
+{{APIRef("Geometry Interfaces")}}{{AvailableInWorkers}}
+
+The `skewY()` method of the {{domxref("DOMMatrixReadOnly")}} interface is a transformation method that returns a new {{domxref("DOMMatrix")}} created by applying the specified skew transformation to the source matrix along its Y-axis. The original matrix is not modified.


Suggested change

The `skewY()` method of the {{domxref("DOMMatrixReadOnly")}} interface is a transformation method that returns a new {{domxref("DOMMatrix")}} created by applying the specified skew transformation to the source matrix along its Y-axis. The original matrix is not modified.

The `skewY()` method of the {{domxref("DOMMatrixReadOnly")}} interface returns a new {{domxref("DOMMatrix")}} created by applying the specified skew transformation to the source matrix along its Y-axis. The original matrix is not modified.

Same comment about Y-axis or Y axis.

wbamberg · 2025-01-09T04:16:04Z

files/en-us/web/api/dommatrixreadonly/skewy/index.md

+
+The `skewY()` method of the {{domxref("DOMMatrixReadOnly")}} interface is a transformation method that returns a new {{domxref("DOMMatrix")}} created by applying the specified skew transformation to the source matrix along its Y-axis. The original matrix is not modified.
+
+To mutate the matrix as you skew it along the Y-axis, see {{domxref("DOMMatrix.skewYSelf()")}}


Suggested change

To mutate the matrix as you skew it along the Y-axis, see {{domxref("DOMMatrix.skewYSelf()")}}

To mutate the matrix as you skew it along the Y-axis, see {{domxref("DOMMatrix.skewYSelf()")}}.

New pages: DOMMatrixReadOnly.skewX/skewY/rotate

5600111

estelle requested a review from a team as a code owner December 9, 2024 19:50

estelle requested review from wbamberg and removed request for a team December 9, 2024 19:50

github-actions bot added Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed labels Dec 9, 2024

estelle added 4 commits December 9, 2024 14:58

New pages: dommatrix scale3D

33e2b39

typo

7cf0215

typo

6fe05c7

rotateaxisangle and rotatefromvector

f7e257e

github-actions bot added size/l [PR only] 501-1000 LoC changed and removed size/m [PR only] 51-500 LoC changed labels Dec 10, 2024

estelle and others added 13 commits December 10, 2024 09:54

typo

39d5a4c

Update index.md

843aa7a

return value and typo

c4806be

return value

2d921d7

Update index.md

34ee15c

Update index.md

3483bc8

Update index.md

fa88e82

return

41be995

return

6ea41a6

return value

f39d646

Update index.md

3d57f00

Merge branch 'main' into dmrotransforms

47b12b8

Merge branch 'main' into dmrotransforms

11179e1

wbamberg reviewed Jan 9, 2025

View reviewed changes

estelle and others added 3 commits January 11, 2025 08:41

Merge branch 'main' into dmrotransforms

fd02178

Edits per review

3744e18

Edits per review

ddfc003

estelle added 9 commits January 11, 2025 14:21

Edits per review

21787b6

Edits per review

aa20b84

Edits per review

e053b27

Edits per review

bf93ec9

Edits per review

ac87cea

edits

5050463

moved

e09fa62

nits

7e75c92

nits

2d3f23d

estelle requested a review from wbamberg January 12, 2025 03:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New pages: DOMMatrixReadOnly.skewX/skewY/rotate #37152

New pages: DOMMatrixReadOnly.skewX/skewY/rotate #37152

estelle commented Dec 9, 2024

github-actions bot commented Dec 9, 2024 •

edited

Loading

wbamberg left a comment

wbamberg Jan 8, 2025

wbamberg Jan 8, 2025

wbamberg Jan 8, 2025

wbamberg Jan 9, 2025

wbamberg Jan 9, 2025

wbamberg Jan 9, 2025

wbamberg Jan 9, 2025

wbamberg Jan 9, 2025

wbamberg Jan 9, 2025

wbamberg Jan 9, 2025

wbamberg Jan 9, 2025

wbamberg Jan 9, 2025

wbamberg Jan 9, 2025

		The `rotateAxisAngleSelf()` method of the {{domxref("DOMMatrix")}} interface is a transformation method that returns a new {{domxref("DOMMatrix")}} created by rotating the source matrix by the given vector and angle. The original matrix is not altered.

		To rotate a matrix without mutating it, see {{domxref("DOMMatrix.rotateAxisAngleSelf()")}}


		{{APIRef("Geometry Interfaces")}}{{AvailableInWorkers}}

		The `rotateFromVectorSelf()` method of the {{domxref("DOMMatrix")}} interface is a mutable transformation method that modifies a matrix. It modifies the matrix by rotating the matrix by the angle between the specified vector and `(1, 0)`. The rotation angle is determined by the angle between the vector `(1,0)T` and `(x,y)T` in the clockwise direction, or `(+/-)arctan(y/x)`. If `x` and `y` are both `0`, the angle is specified as `0`, returning the altered {{domxref("DOMMatrix")}}.

	To mutate the matrix as you 3D-rotate it, see {{domxref("DOMMatrix.scale3dSelf()")}}
	To mutate the matrix as you 3D-scale it, see {{domxref("DOMMatrix.scale3dSelf()")}}.


		{{APIRef("Geometry Interfaces")}}{{AvailableInWorkers}}

		The `skewX()` method of the {{domxref("DOMMatrixReadOnly")}} interface is a transformation method that returns a new {{domxref("DOMMatrix")}} created by applying the specified skew transformation to the source matrix along its X-axis. The original matrix is not modified.


		The `skewX()` method of the {{domxref("DOMMatrixReadOnly")}} interface is a transformation method that returns a new {{domxref("DOMMatrix")}} created by applying the specified skew transformation to the source matrix along its X-axis. The original matrix is not modified.

		To mutate the matrix as you skew it along the X-axis, see {{domxref("DOMMatrix.skewXSelf()")}}


		{{APIRef("Geometry Interfaces")}}{{AvailableInWorkers}}

		The `skewY()` method of the {{domxref("DOMMatrixReadOnly")}} interface is a transformation method that returns a new {{domxref("DOMMatrix")}} created by applying the specified skew transformation to the source matrix along its Y-axis. The original matrix is not modified.

New pages: DOMMatrixReadOnly.skewX/skewY/rotate #37152

Are you sure you want to change the base?

New pages: DOMMatrixReadOnly.skewX/skewY/rotate #37152

Conversation

estelle commented Dec 9, 2024

github-actions bot commented Dec 9, 2024 • edited Loading

wbamberg left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Dec 9, 2024 •

edited

Loading