Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove heading from above summary to ensure valid HTML #37558

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

novellac
Copy link
Contributor

@novellac novellac commented Jan 8, 2025

Description

This PR moves the h1 tag outside of the details element.

Motivation

Having the h1 above the summary element was invalid HTML, and since the h1 seemed to describe both of the details elements, it seemed like it would be better placed outside of the details element altogether.

Additional details

Related issues and pull requests

@novellac novellac requested a review from a team as a code owner January 8, 2025 19:03
@novellac novellac requested review from chrisdavidmills and removed request for a team January 8, 2025 19:03
@github-actions github-actions bot added Content:HTML Hypertext Markup Language docs size/xs [PR only] 0-5 LoC changed labels Jan 8, 2025
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Preview URLs

Flaws (23)

URL: /en-US/docs/Web/HTML/Element/summary
Title: <summary>: The Disclosure Summary element
Flaw count: 23

  • macros:
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/HTML
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/Getting_started_with_the_web/HTML_basics
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/HTML/Introduction_to_HTML
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/HTML/Introduction_to_HTML/Getting_started
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/HTML/Introduction_to_HTML/The_head_metadata_in_HTML
    • and 18 more flaws omitted

Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you @novellac !

@wbamberg wbamberg merged commit 626b8fa into mdn:main Jan 9, 2025
7 checks passed
@novellac novellac deleted the patch-1 branch January 9, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:HTML Hypertext Markup Language docs size/xs [PR only] 0-5 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants