-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pr test new ci #37572
Pr test new ci #37572
Conversation
# and it can't use the default CONTENT_ROOT that gets set in | ||
# package.json. | ||
echo Y|yarn rari update | ||
ARGS=$(echo $GIT_DIFF_CONTENT | sed -E -e "s#(^| )files#\1-f $PWD/files#g") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This converts the args to absolute path and adds a -f
for each.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps add this as a comment inline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a throwaway file to test if it works. I'll change this in the real PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, particularly the "only run with a [new-ci]
prefix" part
# and it can't use the default CONTENT_ROOT that gets set in | ||
# package.json. | ||
echo Y|yarn rari update | ||
ARGS=$(echo $GIT_DIFF_CONTENT | sed -E -e "s#(^| )files#\1-f $PWD/files#g") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps add this as a comment inline
Description
This is preliminary work to move to rari as default in content. Since CI is hard to test, let's test it live!
Additional details
This does not affect our regular business (unless folks use
[new-ci]
in the PR title).