Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr test new ci #37572

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Pr test new ci #37572

merged 2 commits into from
Jan 9, 2025

Conversation

fiji-flo
Copy link
Contributor

@fiji-flo fiji-flo commented Jan 9, 2025

Description

This is preliminary work to move to rari as default in content. Since CI is hard to test, let's test it live!

Additional details

This does not affect our regular business (unless folks use [new-ci] in the PR title).

@fiji-flo fiji-flo requested a review from a team as a code owner January 9, 2025 15:29
@github-actions github-actions bot added system [PR only] Infrastructure and configuration for the project size/m [PR only] 51-500 LoC changed labels Jan 9, 2025
# and it can't use the default CONTENT_ROOT that gets set in
# package.json.
echo Y|yarn rari update
ARGS=$(echo $GIT_DIFF_CONTENT | sed -E -e "s#(^| )files#\1-f $PWD/files#g")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This converts the args to absolute path and adds a -f for each.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps add this as a comment inline

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a throwaway file to test if it works. I'll change this in the real PR

Copy link
Member

@LeoMcA LeoMcA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, particularly the "only run with a [new-ci] prefix" part

# and it can't use the default CONTENT_ROOT that gets set in
# package.json.
echo Y|yarn rari update
ARGS=$(echo $GIT_DIFF_CONTENT | sed -E -e "s#(^| )files#\1-f $PWD/files#g")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps add this as a comment inline

@fiji-flo fiji-flo merged commit 08112b5 into main Jan 9, 2025
8 of 9 checks passed
@fiji-flo fiji-flo deleted the pr-test-new-ci branch January 9, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/m [PR only] 51-500 LoC changed system [PR only] Infrastructure and configuration for the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants