added correct explanations to offsets in selection api docs #37630
+6
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Content:WebAPI
|
Preview URLs (comment last updated: 2025-01-14 08:59:12) |
bsmth
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Selection api anchorOffset and focusOffset docs are hugely misleading and data on this matter is very scarce. I clarified what those offset return in the case of a non texty node in anchorNode or focusNode
Motivation
A custom project I am working on heavily reliant on selection api. The docs on this matter are scarce and there are a lot of caveats not mentioned anywhere or in very obscure parts of programming forums. This specificly came up from testing my project and this SO issue which also mentions fixing MDN docs but i guessed there was a regression from 2013 to today.