Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove links to images #38826

Merged
merged 1 commit into from
Mar 27, 2025
Merged

Remove links to images #38826

merged 1 commit into from
Mar 27, 2025

Conversation

Josh-Cena
Copy link
Member

The images are already visible inline; there's no point to open them on their own page. Plus the SVG links don't work anyway.

@Josh-Cena Josh-Cena requested a review from a team as a code owner March 26, 2025 20:56
@Josh-Cena Josh-Cena requested review from hamishwillee and Copilot and removed request for a team and hamishwillee March 26, 2025 20:56
@github-actions github-actions bot added Content:SVG SVG docs Content:Media Media docs labels Mar 26, 2025
@Josh-Cena Josh-Cena requested a review from bsmth March 26, 2025 20:56
@github-actions github-actions bot added the size/s [PR only] 6-50 LoC changed label Mar 26, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes unnecessary links to images that are already displayed inline, addressing both the redundancy in navigation and non-functioning SVG links.

  • Removed anchor tags wrapping image elements in the video codecs guide
  • Removed Markdown links for SVG images in the SVG reference

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

File Description
files/en-us/web/media/guides/formats/video_codecs/index.md Removed tags wrapping elements to display images inline
files/en-us/web/svg/reference/attribute/begin/index.md Removed Markdown links for SVG images that are non-functional given the inline embed
Comments suppressed due to low confidence (1)

files/en-us/web/svg/reference/attribute/begin/index.md:176

  • [nitpick] After removing the SVG link, please verify that the vertical spacing around the EmbedLiveSample remains consistent and does not introduce unwanted extra whitespace.
-[begin-1-offset.svg](begin-1-offset.svg)

Copy link
Contributor

Preview URLs

Flaws (9)

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/SVG/Reference/Attribute/begin
Title: begin
Flaw count: 9

  • macros:
    • Macro produces link /en-US/docs/Web/SVG/Element/animate which is a redirect
    • Macro produces link /en-US/docs/Web/SVG/Element/animateMotion which is a redirect
    • Macro produces link /en-US/docs/Web/SVG/Element/animateTransform which is a redirect
    • Macro produces link /en-US/docs/Web/SVG/Element/discard which is a redirect
    • Macro produces link /en-US/docs/Web/SVG/Element/set which is a redirect
    • and 4 more flaws omitted
External URLs (2)

URL: /en-US/docs/Web/SVG/Reference/Attribute/begin
Title: begin

Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 👍🏻

@Josh-Cena Josh-Cena merged commit 3d5a03e into mdn:main Mar 27, 2025
7 checks passed
@Josh-Cena Josh-Cena deleted the rm-img-link branch March 27, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Media Media docs Content:SVG SVG docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants