-
Notifications
You must be signed in to change notification settings - Fork 23k
Add standard names for Device Client hints #42351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MDN follows BCD, and BCD keeps information for 2 years after a feature is removed from all browsers.
So the way this is handled really depends on what you do in BCD - e.g. if there is just one record with an alias then you might delete and redirect one of the records as done here.
Personally I would maintain the both records in BCD, and also maintain the pages in MDN. Deletion would then happen 2 years after all browsers stop supporting a particular header name - such as DPR.
|
I was trying to avoid duplication of content, but since both are still supported for now that's a fair call. Added back now so PTAL. |
|
This pull request has merge conflicts that must be resolved before it can be merged. |
Fixed |
24fde09 to
4697987
Compare
a26abd9 to
e5fcc78
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tunetheweb , FYI, I've squash merged and rebased all your commits. This is of course not "necessary", but I find it much easier to keep things up to date and understand thinking if changes are needed using a rebase merge rather than just merging main. Hope this does not annoy you.
EDIT Also added some review comments. Most of these are arguable, but I think provide about the right level of cross linking. The actual new content LGTM.
files/en-us/web/http/reference/headers/sec-ch-device-memory/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/http/reference/headers/sec-ch-viewport-width/index.md
Outdated
Show resolved
Hide resolved
|
Thanks for the thorough review @hamishwillee ! I've accepted most of the feedback but have an outstanding comment about one of the pieces of feedback (x3). I have a slight preference to keep it as I'd written to it, but not 100% wedded to it if you feel strongly about this. |
files/en-us/web/http/reference/headers/sec-ch-viewport-height/index.md
Outdated
Show resolved
Hide resolved
hamishwillee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tunetheweb - appreciate your patience.
|
And yours! And your thoughtful reviews. Good to merge from my end! |
Description
Sec-CHnames.Sec-CH-Viewport-Heightpage.Sec-CH-variants to their old names.Motivation
Fix developer confusion: https://bsky.app/profile/ericportis.com/post/3m7oa4vo5fk2q
Additional details
Device-Memory, DPR and Width were added in Chrome 97: https://chromestatus.com/feature/6658223894429696 (note Device-Memory was not noted there)
Height was added in Chrome 105: https://chromestatus.com/feature/5646861215989760
Related issues and pull requests
BCD changes: mdn/browser-compat-data#28636