Skip to content

Conversation

@pepelsbey
Copy link
Member

@pepelsbey pepelsbey commented May 28, 2025

Description

Disabling interactive elements is not a good idea: they are still focusable and very confusing for screen readers. It’s better not to render them at all or render something inert instead. I’d suggest the simplest solution: render nothing.

Note

Also, linter gives me the following error on line 148:

This attribute binds the type 'DirectiveResult<{ prototype: any; directiveName: string; resultType: number; new(partInfo: ChildPartInfo | AttributePartInfo | ElementPartInfo) => UnsafeHTMLDirective; }> | undefined' which can end up binding the string 'undefined'. Use the 'ifDefined' directive?

@pepelsbey pepelsbey requested a review from fiji-flo May 28, 2025 12:31
@caugner
Copy link
Contributor

caugner commented Jul 1, 2025

This was meanwhile fixed by e2fc465.

@caugner caugner closed this Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants